Open
Conversation
b11eec3 to
398b5db
Compare
dalg24
reviewed
Apr 7, 2023
This was referenced Sep 12, 2023
59c81e8 to
457b822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
for_each_extentsexamples as two separate files. This addresses common user questions about mdspan iteration, expressed in issues such as #202.The first example relies on
std::views::cartesian_productandstd::views::iota, which are C++23 features that only GCC 13 currently implements. The second example does not use ranges at all, but it does depend on lambdas being able to accept an explicit template parameter list, a C++20 feature. The example could be rewritten not to depend on that, but it would be more verbose and generally less useful as an example in that case. Both examples use macros to skip compilation in case the required features are not available.